fix: add missing .attrs support in parquet serialisation#4079
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
|
ianna
left a comment
ianna
left a comment
There was a problem hiding this comment.
@albert-physics - Thanks for contributing! Please update the PR title -- please check the following guidelines:
Available types:
- feat: A new feature
- fix: A bug fix
- docs: Documentation only changes
- style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
- refactor: A code change that neither fixes a bug nor adds a feature
- perf: A code change that improves performance
- test: Adding missing tests or correcting existing tests
- build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
- ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
- chore: Other changes that don't modify src or test files
- revert: Reverts a previous commit
albert-physics
changed the title
|
Fixed the title, I thought it would pick up the title from the last commit name. I have listed this as "fix" mainly because the linked issue referred to it as a bug which required fixing opposed to a new feature. I have been performing tests locally so am slightly surprised by the failures in the CI. These errors all seem to be from |
|
Some CI tests use an old version of pandas. I have updated the test for reading .attrs from parquet files written with pandas 2.1.0+. After this is looks like all checks pass |
ianna
left a comment
ianna
left a comment
There was a problem hiding this comment.
@albert-physics — thanks for implementing this! It looks great.
|
@all-contributors please add @albert-physics for code |
|
The PR description includes the phrase "not close 3278". But I think that GitHub ignored "not" and still closed the issue. I'll reopen the issue. |
3 participants
Makes parquet serialisation support reading and writing the
.attrsof arrays. This method should also read.attrswritten by pandas though has an implicit casting fromdicttoAttrswhich only allows string keys. Tests have been written to test both awkward attrs reading and writing and pandas attrs reading.This is connected to but does not close #3278 as this does not add support to arrow